search

spotbugs / spotbugs-maven-plugin

Maven Mojo Plug-In to generate reports based on the SpotBugs Analyzer
https://spotbugs.github.io/spotbugs-maven-plugin/
Apache License 2.0
69 stars 51 forks source link

Proposal to change copyright holder described in maven site #107

Closed KengoTODA closed 5 years ago

KengoTODA commented 5 years ago

Currently our site generated by Maven uses @hazendaz's name as copyright holder of this project, because our site skin uses <organization> info in pom.xml and the parent project uses his name as organization.

In my understanding, the copyright holder of this project is @gleclaire, then I propose to add <organization> into this pom.xml to overwrite config in parent project.

@gleclaire @hazendaz could you review this PR? Thanks in advance! :)

hazendaz commented 5 years ago

Looks good! Go ahead and merge it.

Get Outlook for Androidhttps://aka.ms/ghei36

From: Kengo TODA notifications@github.com Sent: Thursday, February 21, 2019 10:40:20 PM To: spotbugs/spotbugs-maven-plugin Cc: Jeremy Landis; Review requested Subject: Re: [spotbugs/spotbugs-maven-plugin] Proposal to change copyright holder described in maven site (#107)

@KengoTODAhttps://github.com/KengoTODA requested your review on: #107https://github.com/spotbugs/spotbugs-maven-plugin/pull/107 Proposal to change copyright holder described in maven site.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/spotbugs/spotbugs-maven-plugin/pull/107#event-2156821416, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA7ho7CAUdsnKfjJW_dyvrc3hGyJvIMvks5vP2akgaJpZM4bIzLS.

KengoTODA commented 5 years ago

note: CI build is broken, but it can be fixed by #108.

hazendaz commented 5 years ago

The git ignore on jar file. That location didn't change best I can tell from release notes on maven wrapper. If my assumption is correct, usage of the wrapper will still put artifact into git scope without the exclusion. Can you confirm that?

Get Outlook for Androidhttps://aka.ms/ghei36

From: Kengo TODA notifications@github.com Sent: Thursday, February 21, 2019 10:52:22 PM To: spotbugs/spotbugs-maven-plugin Cc: Jeremy Landis; Mention Subject: Re: [spotbugs/spotbugs-maven-plugin] Proposal to change copyright holder described in maven site (#107)

note: CI build is broken, but it can be fixed by #108https://github.com/spotbugs/spotbugs-maven-plugin/pull/108.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/spotbugs/spotbugs-maven-plugin/pull/107#issuecomment-466264160, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA7ho_Wx-NPAdjo_i0thag57Y9ExC66Iks5vP2l2gaJpZM4bIzLS.

KengoTODA commented 5 years ago

README said that jar file isn't must. However, on Travis, it is possible to throw exception and its reason is unclear. I think 19a454291f8d67e01962e65b301fccbd58263c0d is valuable to stabilize situation like this.

hazendaz commented 5 years ago

I dont believe so. I'll take a look later though. Entire purpose of half the files in the wrapper was to remove the jar.

Get Outlook for Androidhttps://aka.ms/ghei36

From: Kengo TODA notifications@github.com Sent: Thursday, February 21, 2019 11:45:38 PM To: spotbugs/spotbugs-maven-plugin Cc: Jeremy Landis; Mention Subject: Re: [spotbugs/spotbugs-maven-plugin] Proposal to change copyright holder described in maven site (#107)

READMEhttps://github.com/takari/maven-wrapper#usage-without-binary-jar said that jar file isn't must. However, on Travis, it is possible to throw exceptionhttps://travis-ci.org/spotbugs/spotbugs-maven-plugin/jobs/496852347 and its reason is unclear. I think 19a4542https://github.com/spotbugs/spotbugs-maven-plugin/commit/19a454291f8d67e01962e65b301fccbd58263c0d is valuable to stabilize situation like this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/spotbugs/spotbugs-maven-plugin/pull/107#issuecomment-466272173, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA7hoyO8DUbzfrhNfzyw0k4UFnHN_qYLks5vP3XygaJpZM4bIzLS.

hazendaz commented 5 years ago

@KengoTODA Sorry mixed the conversation on maven wrapper on wrong thread. The issue you were seeing was due to a bug introduced in maven wrapper 0.5.2. I reported the issue and it was fixed on Friday. I did raise up to maven wrapper 0.5.2 separately with the proposed patch I suggested and it is working fine without the jar as expected. I'm going to cancel that PR and will add this note there as well.