search

spotbugs / spotbugs-maven-plugin

Maven Mojo Plug-In to generate reports based on the SpotBugs Analyzer
https://spotbugs.github.io/spotbugs-maven-plugin/
Apache License 2.0
69 stars 51 forks source link

Make sarifOutputDirectory and sarifOutputFilename configurable #508

Closed jwgmeligmeyling closed 1 year ago

jwgmeligmeyling commented 1 year ago

Fixes #506 Fixes #507

hazendaz commented 1 year ago

@jwgmeligmeyling The force file happens earlier, is it needed to happen there as well? Seems like its happening twice with this change. The first call happens already right after the point you use the new parameters added here. Few lines below.

jwgmeligmeyling commented 1 year ago

The other forceFile only happens on the temporary file location, not the resultFile. The resultFile relied on the forceFile(temporaryResult) to create the parent folders, but with this change these folders may now differ. I actually amended it to my copy later when I noticed it wasn't working.

hazendaz commented 1 year ago

Totally missed that key difference. Thanks. Will get this merged in and a release sometime this weekend.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jan-Willem Gmelig Meyling @.> Sent: Saturday, November 5, 2022 9:49:43 AM To: spotbugs/spotbugs-maven-plugin @.> Cc: Jeremy Landis @.>; Comment @.> Subject: Re: [spotbugs/spotbugs-maven-plugin] Make sarifOutputDirectory and sarifOutputFilename configurable (PR #508)

The other forceFile only happens on the temporary file location, not the resultFile. The resultFile relied on the forceFile(temporaryResult) to create the parent folders, but with this change these folders may now differ. I actually amended it to my copy later when I noticed it wasn't working.

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fspotbugs%2Fspotbugs-maven-plugin%2Fpull%2F508%23issuecomment-1304550215&data=05%7C01%7C%7C3eefa1030f6142e285cc08dabf3498b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638032529872027860%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=66s9Q5VYvAZ%2Fk6ujlvZifS4WgyxPdcK2gRQyk%2FB3rFI%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHODIY72AGOWLENAEYCYJ3WGZQXPANCNFSM6AAAAAARWQHIVU&data=05%7C01%7C%7C3eefa1030f6142e285cc08dabf3498b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638032529872184114%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=KPEM3gM5%2FWlzbpE9pzBVAKejk0%2B%2BmAkfElH1U6b0whM%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>

hazendaz commented 1 year ago

@jwgmeligmeyling This has been released as 4.7.2.2 now.

jwgmeligmeyling commented 1 year ago

Thanks! 👍🏻