lifecycle-mapping-metadata.xml should contain goal of spotbugs-maven-plugin

spotbugs / spotbugs-maven-plugin

Maven Mojo Plug-In to generate reports based on the SpotBugs Analyzer

https://spotbugs.github.io/spotbugs-maven-plugin/

Apache License 2.0

69 stars 51 forks source link

lifecycle-mapping-metadata.xml should contain goal of spotbugs-maven-plugin #68

Closed KengoTODA closed 2 years ago

KengoTODA commented 5 years ago

At here we have <goal>compile</goal>. The compile is not goal of our plugin but phase in Maven lifecycle. It should be <goal>check</goal> to run SpotBugs plugin at the timing to build.

refs https://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html

KengoTODA commented 5 years ago

I'm not sure this fix is enough to link maven-spotbugs-plugin with m2e. Maybe we need some additional bridge to report detected issues in editor?

hazendaz commented 5 years ago

I think that is likely enough. I've had luck with other plugins by defining that myself in super pom in other cases. At the very least, can you raise a PR to fix the issue?

KengoTODA commented 5 years ago

YES I will.

hazendaz commented 5 years ago

Fixed by #69. I don't think there is any need for anything more with m2e.

hazendaz commented 5 years ago

Sorry, reopening. I thought this had been merged.