search

spotfiresoftware / spotfire-python

Package for Building Python Extensions to Spotfire®
Other
18 stars 6 forks source link

Add fast implementation of SBDF reading developed by PDF Solutions #10

Closed luke-pdf closed 1 year ago

luke-pdf commented 3 years ago

This PR contributes the fast SBDF reader code developed within PDF Solutions to read SBDF files 1-3 orders of magnitude faster than the implementation currently in this repository.

jorobert commented 3 years ago

Hi @luke-pdf ! Thanks so much for contributing this! Sorry for our delay in incorporating it. Finally getting around to pulling all of these in and hope to get this incorporated in the coming week.

bbassett-tibco commented 1 year ago

Hi @luke-pdf ! We've decided to go a different direction to improve the performance of SBDF import/export (use Cython to build a native extension with the same C library we use on other engines; merged into the 2.0.0 release with #36). We definitely appreciate the contribution, but were unable to utilize it due to the fact that it is an incomplete implementation (it's missing a number of data types, and completely missing export; also, the additional Python package requirement of numba is additional effort).