spotfiresoftware / spotfire-python

Package for Building Python Extensions to Spotfire®
Other
18 stars 6 forks source link

New version of pylint (2.17.2) identifies new issues #38

Closed github-actions[bot] closed 10 months ago

github-actions[bot] commented 1 year ago

A version of pylint is available in the Python package repositories that identifies issues with the spotfire package. Since we attempt to keep all pylint issues out of the source code (either by fixing the issue identified or by disabling that message with a localized comment), this is indicative of a new check in this new version of pylint.

Please investigate these issues, and either fix the source or disable the check with a comment. Further checks by this automation will be held until this issue is closed. Make sure that the fix updates the pylint requirement in requirements_lint.txt to the version identified here (2.17.2).

For reference, here is the output of this version of pylint:

$ pylint spotfire
************* Module spotfire.public
spotfire/public.py:12: [E0611, ] No name 'sbdf' in module 'spotfire' (no-name-in-module)
************* Module spotfire.data_function
spotfire/data_function.py:15: [E0611, ] No name 'sbdf' in module 'spotfire' (no-name-in-module)
************* Module spotfire.test.test_data_function
spotfire/test/test_data_function.py:13: [E0611, ] No name 'sbdf' in module 'spotfire' (no-name-in-module)
************* Module spotfire.test.test_sbdf
spotfire/test/test_sbdf.py:14: [E0611, ] No name 'sbdf' in module 'spotfire' (no-name-in-module)

-----------------------------------
Your code has been rated at 9.86/10

This issue was automatically opened by the pylint.yaml workflow.

bbassett-tibco commented 10 months ago

After updating the Python version list to include 3.12, the "build.yaml" workflow started breaking during "Static Analysis". When updating the "pylint" requirement, remove the workaround I jut put into place to lock it to Python 3.11 (which did work with the frozen pylint version).

bbassett-tibco commented 10 months ago

Pylint is updated to the current version, 3.0.3. I've also gone in and audited all the pylint: disable=... comments to see if they were still needed.