spotfiresoftware / spotfire-python

Package for Building Python Extensions to Spotfire®
Other
18 stars 6 forks source link

New version of pylint (3.2.2) identifies new issues #68

Closed github-actions[bot] closed 4 months ago

github-actions[bot] commented 4 months ago

A version of pylint is available in the Python package repositories that identifies issues with the spotfire package. Since we attempt to keep all lint issues out of the source code (either by fixing the issue identified or by disabling that message with a localized comment), this is indicative of a new check in this new version of pylint.

Please investigate these issues, and either fix the source or disable the check with a comment. Further checks by this automation will be held until this issue is closed. Make sure that the fix updates the pylint requirement in pyproject.toml (the lint key of the project.optional-dependencies section) to the version identified here (3.2.2).

For reference, here is the output of this version of pylint:

$ pylint spotfire
************* Module spotfire.codesign
spotfire/codesign.pyi:1: [C0114, ] Missing module docstring (missing-module-docstring)
spotfire/codesign.pyi:9: [C0115, CertificateStoreLocation] Missing class docstring (missing-class-docstring)
spotfire/codesign.pyi:13: [C0116, codesign_file] Missing function or method docstring (missing-function-docstring)
spotfire/codesign.pyi:13: [W0613, codesign_file] Unused argument 'filename' (unused-argument)
spotfire/codesign.pyi:13: [W0613, codesign_file] Unused argument 'certificate' (unused-argument)
spotfire/codesign.pyi:13: [W0613, codesign_file] Unused argument 'password' (unused-argument)
spotfire/codesign.pyi:13: [W0613, codesign_file] Unused argument 'timestamp' (unused-argument)
spotfire/codesign.pyi:14: [W0613, codesign_file] Unused argument 'use_rfc3161' (unused-argument)
spotfire/codesign.pyi:14: [W0613, codesign_file] Unused argument 'use_sha256' (unused-argument)
spotfire/codesign.pyi:15: [C0116, codesign_file_from_store] Missing function or method docstring (missing-function-docstring)
spotfire/codesign.pyi:15: [R0913, codesign_file_from_store] Too many arguments (7/6) (too-many-arguments)
spotfire/codesign.pyi:15: [W0613, codesign_file_from_store] Unused argument 'filename' (unused-argument)
spotfire/codesign.pyi:15: [W0613, codesign_file_from_store] Unused argument 'store_location' (unused-argument)
spotfire/codesign.pyi:15: [W0613, codesign_file_from_store] Unused argument 'store_name' (unused-argument)
spotfire/codesign.pyi:16: [W0613, codesign_file_from_store] Unused argument 'store_cn' (unused-argument)
spotfire/codesign.pyi:16: [W0613, codesign_file_from_store] Unused argument 'timestamp' (unused-argument)
spotfire/codesign.pyi:17: [W0613, codesign_file_from_store] Unused argument 'use_rfc3161' (unused-argument)
spotfire/codesign.pyi:17: [W0613, codesign_file_from_store] Unused argument 'use_sha256' (unused-argument)
************* Module spotfire.cabfile
spotfire/cabfile.pyi:1: [C0114, ] Missing module docstring (missing-module-docstring)
spotfire/cabfile.pyi:8: [C0115, CabFile] Missing class docstring (missing-class-docstring)
spotfire/cabfile.pyi:9: [W0613, CabFile.__init__] Unused argument 'file' (unused-argument)
spotfire/cabfile.pyi:10: [E0602, CabFile.__enter__] Undefined variable 'CabFile' (undefined-variable)
spotfire/cabfile.pyi:13: [C0116, CabFile.write] Missing function or method docstring (missing-function-docstring)
spotfire/cabfile.pyi:13: [W0613, CabFile.write] Unused argument 'filename' (unused-argument)
spotfire/cabfile.pyi:13: [W0613, CabFile.write] Unused argument 'arcname' (unused-argument)
spotfire/cabfile.pyi:14: [C0116, CabFile.writestr] Missing function or method docstring (missing-function-docstring)
spotfire/cabfile.pyi:14: [W0613, CabFile.writestr] Unused argument 'arcname' (unused-argument)
spotfire/cabfile.pyi:14: [W0613, CabFile.writestr] Unused argument 'data' (unused-argument)
spotfire/cabfile.pyi:15: [C0116, CabFile.close] Missing function or method docstring (missing-function-docstring)
************* Module spotfire.sbdf
spotfire/sbdf.pyi:1: [C0114, ] Missing module docstring (missing-module-docstring)
spotfire/sbdf.pyi:7: [C0115, SBDFError] Missing class docstring (missing-class-docstring)
spotfire/sbdf.pyi:7: [C0321, SBDFError] More than one statement on a single line (multiple-statements)
spotfire/sbdf.pyi:8: [C0115, SBDFWarning] Missing class docstring (missing-class-docstring)
spotfire/sbdf.pyi:8: [C0321, SBDFWarning] More than one statement on a single line (multiple-statements)
spotfire/sbdf.pyi:10: [C0116, spotfire_typename_to_valuetype_id] Missing function or method docstring (missing-function-docstring)
spotfire/sbdf.pyi:10: [C0103, spotfire_typename_to_valuetype_id] Function name "spotfire_typename_to_valuetype_id" doesn't conform to '(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$' pattern ('(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$' pattern) (invalid-name)
spotfire/sbdf.pyi:10: [W0613, spotfire_typename_to_valuetype_id] Unused argument 'typename' (unused-argument)
spotfire/sbdf.pyi:11: [C0116, import_data] Missing function or method docstring (missing-function-docstring)
spotfire/sbdf.pyi:11: [W0613, import_data] Unused argument 'sbdf_file' (unused-argument)
spotfire/sbdf.pyi:12: [C0116, export_data] Missing function or method docstring (missing-function-docstring)
spotfire/sbdf.pyi:12: [W0613, export_data] Unused argument 'obj' (unused-argument)
spotfire/sbdf.pyi:12: [W0613, export_data] Unused argument 'sbdf_file' (unused-argument)
spotfire/sbdf.pyi:12: [W0613, export_data] Unused argument 'default_column_name' (unused-argument)
spotfire/sbdf.pyi:13: [W0613, export_data] Unused argument 'rows_per_slice' (unused-argument)
spotfire/sbdf.pyi:13: [W0613, export_data] Unused argument 'encoding_rle' (unused-argument)
************* Module spotfire.data_function
spotfire/data_function.py:128: [E1136, AnalyticInput.read] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/data_function.py:129: [E1136, AnalyticInput.read] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/data_function.py:145: [E1136, AnalyticInput.read] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/data_function.py:335: [R1711, AnalyticSpec._compile_script] Useless return at end of function or method (useless-return)
************* Module spotfire.test.test_sbdf
spotfire/test/test_sbdf.py:51: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:52: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:53: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:54: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:55: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:56: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:57: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:58: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:59: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:60: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:61: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
spotfire/test/test_sbdf.py:62: [E1136, SbdfTest.test_read_0] Value 'dataframe' is unsubscriptable (unsubscriptable-object)
************* Module spotfire.test.test_data_function
spotfire/test/test_data_function.py:124: [E1136, DataFunctionTest._run_analytic] Value 'data_frame' is unsubscriptable (unsubscriptable-object)

-----------------------------------
Your code has been rated at 9.24/10

This issue was automatically opened by the pylint.yaml workflow.