New version of cpplint (2.0.0) identifies new issues

[github-actions[bot]]

A version of cpplint is available in the Python package repositories that identifies issues with the spotfire package. Since we attempt to keep all lint issues out of the source code (either by fixing the issue identified or by disabling that message with a localized comment), this is indicative of a new check in this new version of cpplint.

Please investigate these issues, and either fix the source or disable the check with a comment. Further checks by this automation will be held until this issue is closed. Make sure that the fix updates the cpplint requirement in pyproject.toml (the lint key of the project.optional-dependencies section) to the version identified here (2.0.0).

For reference, here is the output of this version of cpplint:

$ cpplint spotfire/*_helpers.[ch]
Done processing spotfire/cabfile_helpers.c
Done processing spotfire/cabfile_helpers.h
Done processing spotfire/sbdf_helpers.c
Done processing spotfire/sbdf_helpers.h
Total errors found: 2

This issue was automatically opened by the pylint.yaml workflow.

[bbassett-tibco]

Also, clean up the naming of the generated issue title. (This issue was generated with 'pylint' instead of 'cpplint').

[bbassett-tibco]

Note that the cpplint capture was only grabbing stdout, and not stderr (where the actual issues are emitted). The full message from cpplint 2.0.0 is:

$ cpplint spotfire/*_helpers.[ch]
Done processing spotfire/cabfile_helpers.c
Done processing spotfire/cabfile_helpers.h
spotfire/sbdf_helpers.c:30:  Add #include <cstdio> for fopen  [build/include_what_you_use] [4]
Done processing spotfire/sbdf_helpers.c
spotfire/sbdf_helpers.h:15:  Add #include <cstdio> for FILE  [build/include_what_you_use] [4]
Done processing spotfire/sbdf_helpers.h
Total errors found: 2