spotfiresoftware / spotfire-wrapper

An Angular component packaged as custom elements that defined a new HTML element to display a Spotfire dashboard in a framework-agnostic way
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Feature/ng update 9 #71

Closed Gerromie closed 4 years ago

Gerromie commented 4 years ago

Story

Exploring an upgrade of Angular to version 9 for use with another project. Direct Message me for information.

Changes

  1. Ran through the angular upgrade checklist
  2. Modified a few lines in the README that did not work when the steps were followed
  3. (Not done) I think the version should be updated if this request is approved

Tests

None to date. I would like to run this through the demo tools and will direct message you regarding that.

nicolasderoche commented 4 years ago

Hello Jeremy, Before looking at your PR, I resolve old PR (the one created by git Bot and relative to security). And now, I see that your PR cannot be approved due to conflicts (probably libs from previous PRs that shall be sync'ed Could you have a look ? Thanks Nicolas