Feature/expose document

spotfiresoftware / spotfire-wrapper

An Angular component packaged as custom elements that defined a new HTML element to display a Spotfire dashboard in a framework-agnostic way

BSD 3-Clause "New" or "Revised" License

9 stars 6 forks source link

Feature/expose document #77

Closed nicolasderoche closed 4 years ago

nicolasderoche commented 4 years ago

Story

In order to have access to Spotfire Properties, this API may provide a way to list them, get/set value for one of them.

Changes

Expose document: SpotfireDocument that handles the methods getDocumentProperties$(), getDocumentProperty$(propertyName:string) and setDocumentProperty((propertyName: string, value: string | string[])

Tests

A new demo3 shall be added to illustrate the use.

Gerromie commented 4 years ago

This looks good. I tested the demo and saw some warnings and errors on ng serve related to circular source file mapping dependencies and ngcc backup files. These might be local to my environment though I was pretty sure I had started with a clean slate.