search

spotify / XCMetrics

XCMetrics is the easiest way to collect Xcode build metrics and improve developer productivity.
https://xcmetrics.io
Other
1.1k stars 77 forks source link

Mandatory 'excludeCI' parameter breaks the Backstage plugin integration. #106

Open pmfon opened 9 months ago

pmfon commented 9 months ago

Hi,

I'm trying to setup XCMetrics with the Backstage plugin. The dashboard loads, showing the build history, but the Builds tab just shows an error.

After inspecting the response, I found the following message { "error": true, "reason": "Value required for key 'excludeCI'." }

and the same message in the XCMetrics-backend logs xcmetrics-backend-xcmetrics-1 | [ WARNING ] Value required for key 'excludeCI'. [request-id: BE19CCEC-338D-4056-84DD-8F9C6A18D4D6]

I was able to work around this by adding "excludeCI": true to the builds/filter request made from the plugin. I'd be happy to submit a fix for this, just not sure if the plugin is out-of-date or if the backend should handle the excludeCI parameter in a different way.

BalestraPatrick commented 8 months ago

Hey @pmfon! Looks like you're right. That property was added here: https://github.com/spotify/XCMetrics/pull/95

We should add excludeCI to the xcmetrics Backstage plugin which lives here: https://github.com/backstage/backstage/tree/9c91930d25071d16f4f1c84db2c7744b0f34c071/plugins/xcmetrics

Let me know when you have submitted the fix and I can help land it in that repo if needed.

ryanjclark commented 5 months ago

@BalestraPatrick If you are still available to help land this fix in Backstage 🙏.