Add support for Redis server password

spotify / XCMetrics

XCMetrics is the easiest way to collect Xcode build metrics and improve developer productivity.

https://xcmetrics.io

Other

1.1k stars 77 forks source link

Add support for Redis server password #36

Closed dalemyers closed 3 years ago

dalemyers commented 3 years ago

The existing implementation does not support passing in a password. This change allows an envirornment variable REDIS_PASSWORD to be set which will be propagated through.

Here's the catch: This is totally untested. It looks like a straightforward enough change, so I don't foresee any issues, but I haven't yet been able to get things up and running to test. I can probably test at some point, but it will likely be a day or two at minimum before I do.

ecamacho commented 3 years ago

@dalemyers thanks for this! I will test it this week as well before approving it.

dalemyers commented 3 years ago

I haven't tested this change directly (there seems to be an issue with Azure Redis servers that I haven't solved), but I did test it with RediStack directly in a sample and it worked exactly as expected.