Tag and hardware information are missing from the build information

spotify / XCMetrics

XCMetrics is the easiest way to collect Xcode build metrics and improve developer productivity.

https://xcmetrics.io

Other

1.1k stars 77 forks source link

Tag and hardware information are missing from the build information #62

Closed byohay closed 2 years ago

byohay commented 2 years ago

Adding a tag using the environment variable SPT_XCMETRICS_TAG doesn't have any effect. When querying the database the tag comes back empty. I know I set it correctly in the client because I saw the line Started appending a tag "SomeTag" being printed to the Console. The same is true for some of the fields in build/host/:id endpoint

I strongly suspect it has something to do with the AddMetadataEffectHandler.

byohay commented 2 years ago

After debugging it a bit I saw the correct information in MetricsUploadRequest just before being uploaded. So it could be some problem in the backend when processing the response.

byohay commented 2 years ago

The PRs #65 and #64 should solve this.