spotify / XCMetrics

XCMetrics is the easiest way to collect Xcode build metrics and improve developer productivity.
https://xcmetrics.io
Other
1.1k stars 77 forks source link

Update Dockerfile to use Arm64 compatible Swift base image #92

Closed pavlospt closed 1 year ago

pavlospt commented 1 year ago

Hello,

We are using XCMetrics @ Blueground & we are transitioning to Arm64 for our production workloads. Since swift:5.5-bionic did not support Arm64 architecture, this was a blocker for us.

This PR updates the base Docker image to swift:5.6-focal in order to be compatible with Arm64.

Tested locally with the docker-compose-local.yml file! 🎉

pavlospt commented 1 year ago

Hey @ecamacho , is the Docker image release pipeline private? I am not seeing something related in Github workflows 🤔

pavlospt commented 1 year ago

@ecamacho hello again. I see that a new Docker image has been pushed to DockerHub, but unless the pipeline building it runs on Arm architecture, or you start building multiplatform images, it won't publish an Arm Docker image. Is there a way to start building for Arm too?

ecamacho commented 1 year ago

@pavlospt I see, let me take a look at the configuration to see if that can be done

pavlospt commented 1 year ago

@ecamacho I can also open a PR with a Github workflow building an Arm image if that's easier for you!

ecamacho commented 1 year ago

@pavlospt I don't have access yet to our Docker Hub configuration, someone else in my organization configured it. I've raised a request to be able to configure it. I'll keep you posted!

pavlospt commented 1 year ago

@ecamacho great news. Do you want to open an issue from your side in order to track it there, instead of this PR?

ecamacho commented 1 year ago

@pavlospt it's now working for the latest tag. You can find arm64 images in Docker hub:

image

I will create another workflow to create the images for explicit git tags as well next week

pavlospt commented 1 year ago

@ecamacho that's great! Thank you very much for the quick resolution!