search

spotify / XCRemoteCache

Other
835 stars 52 forks source link

Fixes issue #49 #106

Closed alecgarza96 closed 2 years ago

alecgarza96 commented 2 years ago

Fixes issue #49

alecgarza96 commented 2 years ago

added .s file extension for assembly support

polac24 commented 2 years ago

Are you sure this fixes #49? The original problem was reported for CNIOBoringSSL library, which uses *.S (not *.s) files (e.g. https://github.com/apple/swift-nio-ssl/blob/main/Sources/CNIOBoringSSL/crypto/fipsmodule/aesni-gcm-x86_64.linux.x86_64.S). isSuffixed is case sensitive so it wouldn't consider aesni-gcm-x86_64.linux.x86_64.S as a valid input file.

alecgarza96 commented 2 years ago

I can make the change, would it be best to support both .S and .s? Or does CNIOBoringSSL not support *.s at all?

polac24 commented 2 years ago

I think having two or with .s and .S is OK. No idea why CNIOBoringSSL uses .S instead of LLVM-documented .s.

alecgarza96 commented 2 years ago

I committed the changes to this PR and they appear to be reflected when I verify in the Files Changed section. Let me know if this works, or if a new PR should be opened. New to this repo

alecgarza96 commented 2 years ago

image getting following error as reason for failed tests, troubleshooting

polac24 commented 2 years ago

That seem to be a reason of a non-stable test setup. I tried to stabilize it in #81, but still without success.