spotify / XCRemoteCache

Other
825 stars 50 forks source link

`EnvironmentFingerprintGenerator` contains unused code #142

Closed devMEremenko closed 2 years ago

devMEremenko commented 2 years ago

Expected/desired behavior

Hi!

I noticed that EnvironmentFingerprintGenerator declares private generatedFingerprint variable

private var generatedFingerprint: RawFingerprint?

However, there is no mutation, only accessing the initial (nil) value:

if let fingerprint = generatedFingerprint {
    return fingerprint
}

I assume that:

I would fix it if I knew the initial intention.

polac24 commented 2 years ago

Hi! It is the latter case - an incomplete optimization.