search

spotify / XCRemoteCache

Other
825 stars 50 forks source link

Make PUBLIC_HEADERS_FOLDER_PATH ENV optional #164

Closed polac24 closed 1 year ago

polac24 commented 1 year ago

According to #163, PUBLIC_HEADERS_FOLDER_PATH introduced in #149 is not always available - e.g. when CocoaPods build a static library. _For a CocoaPods scenario, take a look on the sourcecode here and note that when a Build Setting is set to an empty string, a build phase script is called without that ENV_.

In such a case, we don't have to automatically rewrite generated -Swift.h file. To skip the rewriting step (introduced in #149) we can leave publicHeadersFolderPath as nil.

The original issue (#149) reports that this problem is caused only when a static library is used (not frameworks).

Fixes #163

polac24 commented 1 year ago

Hi @acbdev, thanks for the review. Do you if getting a write-access to the repo is an automated process? Seems you are not added to the group so github still reports that a review is required.

polac24 commented 1 year ago

Yay! Seems that all is set up correctly, thanks