search

spotify / XCRemoteCache

Other
825 stars 50 forks source link

Is producer-fast mode ready for production environment? #168

Closed CharlieSuP1 closed 1 year ago

CharlieSuP1 commented 1 year ago

I noticed there is 'producer-fast' mode, which is a producer mode, but try to build unchanged projects with remote cache.

And the producer-faster mode is marked with 'experimental', and I wonder why is that? Is producer-fast mode already used in production environment in Spotify?

polac24 commented 1 year ago

This mode has never been verified in a big project and thus marked as experimental.

CharlieSuP1 commented 1 year ago

in hooks.rb，prebuild is disabled for producer-fast mode，is it right? 

     elsif mode == 'producer' || mode == 'producer-fast'
          # Delete existing prebuild build phase (to support switching between modes)
          target.build_phases.delete_if do |phase|
            if phase.respond_to?(:name)
              phase.name != nil && phase.name.start_with?("[XCRC] Prebuild")
            end
          end
        end

In SwiftcOrchestrator.swift, line 121, prebuild step seems to be a must to generate rc.enable file.

polac24 commented 1 year ago

Your concern seems legit, that looks like a bug.