spotify / XCRemoteCache

Other
833 stars 52 forks source link

Reuse existing build phases in CocoaPods plugin #22

Closed mihai8804858 closed 2 years ago

mihai8804858 commented 2 years ago

I've encountered a couple of issues when trying to integrate remote cache using CocoaPods plugin, so this is an attempt to fix them. Here is what has been done and the reasoning:

mihai8804858 commented 2 years ago

To verify that we haven't leaked any absolute paths, you can take a look on all json file uploaded to the remote server in a meta directory - should be correctly mapped.

I looked at the json files uploaded and can confirm that we didn't leak any absolute paths. I see that there are some absolute paths for the modulemaps in the jsons, but this is also true I'm using the plugin from master branch.

polac24 commented 2 years ago

I see that there are some absolute paths for the modulemaps in the jsons

Ups, at glance it sounds like a bug. The json file should not have any paths starting with /. Does your project meet the requirement from the Limitation section?

All compilation files should be referenced via the git repo root. 
Referencing /AbsolutePath/someOther.swift or ../../someOther.swift 
that resolve to the location outside of the git repo root is prohibited.
mihai8804858 commented 2 years ago

Thanks @polac24 for quick feedback! <3