search

spotify / XCRemoteCache

Other
833 stars 52 forks source link

Encode json files using pretty format #30

Closed mihai8804858 closed 2 years ago

mihai8804858 commented 2 years ago

When trying to read the meta files that are uploaded to remote cache, I have to copy-paste them and format using a pretty-print tool. I guess we could encode the meta files using prettyPrinted output formatting so the files can be easily read when testing something 😅 Also, I had to increase the timeout of XCCCTests from 5 to 10 seconds because a test was failing on my machine due to timeout. 🤔

polac24 commented 2 years ago

The meta file is designed to be read by machines and the fact it is human-readable is just a coincident (nice coincident). I checked how much space we can save with a minimized .json and for a big meta file, it is ~6% savings (183KB vs 196 KB).

Saying that, I am not convinced that we should do that by default - would be fine to add it as a parameter to .rcinfo to make it "pretty" opt-in.

mihai8804858 commented 2 years ago

@polac24 Good point. I'll take the time to add a new parameter for "pretty" opt-in, disabled by default.