spotify / XCRemoteCache

Other
833 stars 52 forks source link

Absolute paths in meta files #36

Closed mihai8804858 closed 2 years ago

mihai8804858 commented 2 years ago

Hi,

I am seeing some absolute paths in the uploaded meta files. The paths are part of the .../Build/Intermediates.noindex/...:

{
  ...
  "dependencies": [
    ... 
    "/Users/mseremet/Library/Developer/Xcode/DerivedData/Crunchyroll-exbviznuyvwvwqbtlgbiywhttpfr/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/SDWebImage.build/module.modulemap"
  ]
}

Any idea what causes this?

polac24 commented 2 years ago

Hmm, that should be replaced here: https://github.com/spotify/XCRemoteCache/blob/b6318e97855f8f23b2dc670a8765baad80340d25/Sources/XCRemoteCache/Dependencies/DependencyProcessor.swift#L78-L79

I would check your producer and see if build settings TARGET_TEMP_DIR is a prefix of that path. Build settings can be inspected in Xcode's Report navigator (CMD+9) -> find build script with postbuild -> extend view with a "hamburger" button on the right.

mihai8804858 commented 2 years ago

From Xcode build output:

export TARGET_TEMP_DIR=/Users/mseremet/Library/Developer/Xcode/DerivedData/Crunchyroll-exbviznuyvwvwqbtlgbiywhttpfr/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Vilos.build

From meta file:

{
  "targetName": "Vilos"
  "dependencies": [
    ....
    "/Users/mseremet/Library/Developer/Xcode/DerivedData/Crunchyroll-exbviznuyvwvwqbtlgbiywhttpfr/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/MantleFramework.build/module.modulemap"
  ]
}

Both Vilos and MantleFramework are CocoaPods dependencies added to the main project. And MantleFramework is also a dependency to Vilos.

polac24 commented 2 years ago

Can you provide more details about your Podfile? Is Vilos an objc, swift or a mixed target?

I tried to reproduce it (checked use_modular_headers and use_frameworks) but the modulemap path was always correctly remapped.

polac24 commented 2 years ago

That should be fixed in #71, available since 0.3.4. Can you check if it still occurs on the newest version?