search

spotify / XCRemoteCache

Other
838 stars 52 forks source link

Fix swiftlint warnings #4

Closed polac24 closed 2 years ago

polac24 commented 3 years ago

Swiftlint reports warnings so non-strict linting is performed. Fix all warnings and enabled strict linting mode.

woodencoder commented 2 years ago

Hi @polac24! There seems to be a lot of issues with trailing_dot_in_comments which causes a generic file header to violate SwiftLint rules

// Copyright (c) 2021 Spotify AB. – violates
// Copyright (c) 2021 Spotify AB – passes

Should we maybe disable that rule in .swiftlint.yml?

polac24 commented 2 years ago

I am fine to relax our linting rules and get rid of trailing_dot_in_comments.

polac24 commented 2 years ago

Fixed by https://github.com/spotify/XCRemoteCache/pull/24