polac24 commented 2 years ago

69 reported that for `development_pods` some absolute dependency paths sneak into meta .json file and thus degrade the hit rate.

I looked at how CocoaPods generates development_pods project and it has a unique setup:

SRCROOT is equal to ./Pods
All sources are references within a group that has ".." in it. It is a documented requirement of XCRemoteCache to always reference files within SRCROOT. On the other hand, CocoaPods provide PODS_TARGET_SRCROOT, which points (indirectly) to the development_pod src root:
```
PODS_TARGET_SRCROOT\=some_absolute_path/MovieApp/Pods/../Modules/User
```
The idea is to add PODS_TARGET_SRCROOT into all EVNs that could be rewritten in the dependency identification.

This PR introduces that:

adds an extra property custom_rewrite_envs that allows extending DependenciesMapping.rewrittenEnvs (requested also in #59)
Makes EVN replacement path-aware to eliminate ".." or "." accordingly

Use the sample project shared in #69: https://github.com/dwirandyh/xcremotecache-modular-example Add into Podfile's xcremotecache configuration:

 'custom_rewrite_envs' => ['PODS_TARGET_SRCROOT']

Verify no absolute paths in the User development_pod's json.

vasvf commented 2 years ago

Looks like it's somewhat duplicate of already existing out_of_band_mappings config

polac24 commented 2 years ago

That is correct, yet custom_rewrite_envs is more powerful - it can nicely resolve Build Settings in Xcode build time

spotify / XCRemoteCache