search

spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
158 stars 40 forks source link

remove sketchy recursive pull, and case where we fail silently we log #20

Closed rwstephenson closed 8 years ago

pinux-studio commented 8 years ago

👍

we think this can cause stack overflow and issues such as google pubsub thread being saturated.

I think the recursive pull is just using the google pubsub thread to issue more pull as fast as possible. when there is low volume data, this logic doesn't make much sense.