spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
158 stars 40 forks source link

Add backoff on error to Acker and Puller #28

Closed leblonk closed 7 years ago

leblonk commented 7 years ago

This adds backoff to errors coming back from pubsub. Common case is 429 errors from google due to throttling. Uses a fairly simple linear backoff. @danielnorberg @i-maravic @pinux-studio

codecov-io commented 7 years ago

Codecov Report

Merging #28 into master will increase coverage by 0.21%. The diff coverage is 78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
+ Coverage     75.62%   75.83%   +0.21%     
- Complexity      182      189       +7     
============================================
  Files            24       25       +1     
  Lines           845      894      +49     
  Branches         57       59       +2     
============================================
+ Hits            639      678      +39     
- Misses          173      183      +10     
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...com/spotify/google/cloud/pubsub/client/Puller.java 81.57% <50%> (-2.89%) 20 <0> (ø)
.../com/spotify/google/cloud/pubsub/client/Acker.java 83.33% <66.66%> (-1.52%) 18 <0> (ø)
...om/spotify/google/cloud/pubsub/client/Backoff.java 93.1% <93.1%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92b0f52...e9f97e6. Read the comment docs.

leblonk commented 7 years ago

@danielnorberg @i-maravic @pinux-studio?

rculbertson commented 7 years ago

👍