search

spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
158 stars 40 forks source link

Fixing compatibility with pubsub emulator #30

Closed bilisie closed 7 years ago

bilisie commented 7 years ago

It seems that the google pubsub emulator complains about redundant subscription/publisher names on creation (as they're present in both the payload and the post URL).

I've opened a ticket with google about fixing this on their end but they seem unwilling to do so: https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2199

Here's a sample project that helps reproduce the issue that's being addressed here: https://github.com/bilisie/pubsub-emulator-issue

I've ran the integration tests against prod APIs and I've also tested the code against the emulator.

codecov-io commented 7 years ago

Codecov Report

Merging #30 into master will increase coverage by 0.47%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
+ Coverage     75.83%   76.31%   +0.47%     
- Complexity      189      191       +2     
============================================
  Files            25       25              
  Lines           894      895       +1     
  Branches         59       59              
============================================
+ Hits            678      683       +5     
+ Misses          183      181       -2     
+ Partials         33       31       -2
Impacted Files Coverage Δ Complexity Δ
...otify/google/cloud/pubsub/client/Subscription.java 83.33% <100%> (+1.51%) 7 <1> (+1) :arrow_up:
...com/spotify/google/cloud/pubsub/client/Pubsub.java 76.19% <100%> (ø) 50 <0> (-1) :arrow_down:
.../com/spotify/google/cloud/pubsub/client/Acker.java 87.03% <0%> (+3.7%) 20% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0c10af...a9515ae. Read the comment docs.

bilisie commented 7 years ago

I believe this is related to the current issue that's being reported:

https://github.com/spotify/async-google-pubsub-client/issues/29

danielnorberg commented 7 years ago

LGTM, thanks!