search

spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
157 stars 40 forks source link

Do not unwrap non CompletableException #35

Closed jwiklund closed 6 years ago

jwiklund commented 6 years ago

Avoid unwrapping non CompletableExceptions to avoid hanging on errors.

jwiklund commented 6 years ago

@danielnorberg

codecov-io commented 6 years ago

Codecov Report

Merging #35 into master will increase coverage by 0.27%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage        76%   76.27%   +0.27%     
- Complexity      190      193       +3     
============================================
  Files            26       26              
  Lines           900      902       +2     
  Branches         59       60       +1     
============================================
+ Hits            684      688       +4     
+ Misses          183      181       -2     
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...otify/google/cloud/pubsub/client/PubsubFuture.java 37.31% <100%> (+5%) 16 <0> (+3) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fd72b7...db641c6. Read the comment docs.

danielnorberg commented 6 years ago

Thanks for the PR! I think the issue might be in toCompletableFuture() however, so I submitted an alternative PR #36 to address that.

Does that solve your issue?

danielnorberg commented 6 years ago

Actually after looking/thinking some more I wonder if the CompletionException unwrapping is unnecessary.

Removed it in another commit to #36. Wdyt?

danielnorberg commented 6 years ago

This should be fixed by #36. Closing.