search

spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
158 stars 40 forks source link

Fix PubsubFuture #36

Closed danielnorberg closed 6 years ago

danielnorberg commented 7 years ago

Instead of having toCompletableFuture incorrectly wrap this and expect a CompletionException which will not come, just return this directly.

Alternative to #35

codecov-io commented 7 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.05%. The diff coverage is 90.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage        76%   76.05%   +0.05%     
- Complexity      190      191       +1     
============================================
  Files            26       26              
  Lines           900      902       +2     
  Branches         59       59              
============================================
+ Hits            684      686       +2     
  Misses          183      183              
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...otify/google/cloud/pubsub/client/PubsubFuture.java 31.74% <100%> (-0.57%) 14 <1> (+1)
...com/spotify/google/cloud/pubsub/client/Pubsub.java 76.51% <90%> (+0.31%) 51 <7> (+1) :arrow_up:
...a/com/spotify/google/cloud/pubsub/client/Json.java 66.66% <0%> (-5.56%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fd72b7...a3f7d41. Read the comment docs.