spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
158 stars 40 forks source link

publisher.close()/publisher.closeFuture().get() should flush client #37

Closed bitkid closed 6 years ago

bitkid commented 6 years ago

at least that's what i would expect :) i just modified testPullBatch in PubsubIT. should this test pass?

https://gist.github.com/bitkid/0ccc45d8d58dcf2b1ca88f9f9ed9dec6

danielnorberg commented 6 years ago

Use the future returned by publish() to ensure that the message publication completed before closing the publisher.

bitkid commented 6 years ago

ok thx