spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
158 stars 40 forks source link

Close Pubsub client when Acker or Puller closes #39

Closed sisidra closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #39 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage        76%   76.05%   +0.05%     
  Complexity      190      190              
============================================
  Files            26       26              
  Lines           900      902       +2     
  Branches         59       59              
============================================
+ Hits            684      686       +2     
  Misses          183      183              
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...com/spotify/google/cloud/pubsub/client/Puller.java 81.73% <100%> (+0.16%) 20 <0> (ø) :arrow_down:
.../com/spotify/google/cloud/pubsub/client/Acker.java 83.48% <100%> (+0.15%) 18 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fd72b7...c752d6b. Read the comment docs.

i-maravic commented 6 years ago

+1