search

spotify / async-google-pubsub-client

[SUNSET] Async Google Pubsub Client
Apache License 2.0
157 stars 40 forks source link

Import classes from direct Guava dependency #47

Closed pedro-carneiro closed 5 years ago

pedro-carneiro commented 5 years ago

This change updates some Guava class imports, in order to have them reference the classes from the project's Guava dependency, instead of the repackaged version the google-http-client provides.

codecov[bot] commented 5 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage     76.54%   76.54%           
  Complexity      191      191           
=========================================
  Files            26       26           
  Lines           904      904           
  Branches         59       59           
=========================================
  Hits            692      692           
  Misses          179      179           
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...com/spotify/google/cloud/pubsub/client/Pubsub.java 76.51% <ø> (ø) 51 <0> (ø) :arrow_down:
...a/com/spotify/google/cloud/pubsub/client/Json.java 66.66% <ø> (ø) 4 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63329e5...ee4c8d2. Read the comment docs.

danielnorberg commented 5 years ago

Thanks!

danielnorberg commented 5 years ago

Included in 1.33.