search

spotify / basic-pitch

A lightweight yet powerful audio-to-MIDI converter with pitch bend detection
https://basicpitch.io
Apache License 2.0
3.48k stars 274 forks source link

Piano roll, web demo, tweak nice to have #115

Closed opencoca closed 8 months ago

opencoca commented 8 months ago

At the moment there's no visible time signature or bar lines in the visualization for the midi information. It would be wonderful if while people are exploring and adjusting the tempo, they could see how their notes fell on it.

opencoca commented 8 months ago

Is the source code for the demo in this repo? I haven't found it yet if it is, I'll take a look at doing this myself and submitting a pull request.

opencoca commented 8 months ago

On further review I see that changing the tempo doesn't affect how the music is analyzed but instead only the tempo the resulting midi. IE at the moment changing the tempo changes the length of the resulting midi.

drubinstein commented 8 months ago

The typescript library that powers the demo is open source on github and available via npm.

The web demo is internal and not open sourced however. And yes, your further review is correct.

opencoca commented 8 months ago

If you choose to share the web demo I would be happy to tweak things. You could always publish it under AGPL so that code developed by you and the open source community stays available, and it prevents others from repackaging and selling your open-sourced software. I also understand if corporate doesn't want any AGLP, as a number of companies (I'm looking at you Google) don't allow AGPL.

drubinstein commented 8 months ago

Thanks. We'll talk about it internally. I'm going to close this issue for now, but if we ever decide to open source the website, I'll add a message to this issue.