spotify / basic-pitch

A lightweight yet powerful audio-to-MIDI converter with pitch bend detection
https://basicpitch.io
Apache License 2.0
3.37k stars 261 forks source link

Inconsistent minimum note length #93

Closed matangover closed 1 year ago

matangover commented 1 year ago

Since https://github.com/spotify/basic-pitch/pull/39 was merged, there is an inconsistent minimum note length:

I can make a PR to make it consistently 127.7 ms (11 frames), but that would be backwards incompatible. Is this acceptable?

matangover commented 1 year ago

Also, funnily enough, the minimum note length in basicpitch.io says it's in milliseconds, but it seems to be in frames.

dohertyguirand commented 1 year ago

Hey @matangover, nice catch! I've made a PR to resolve all minimum_note_length to 127.70 ms. Once it is merged I will resolve this issue.

matangover commented 1 year ago

Thank you!