Closed matangover closed 1 year ago
Also, funnily enough, the minimum note length in basicpitch.io says it's in milliseconds, but it seems to be in frames.
Hey @matangover, nice catch! I've made a PR to resolve all minimum_note_length to 127.70 ms. Once it is merged I will resolve this issue.
Thank you!
Since https://github.com/spotify/basic-pitch/pull/39 was merged, there is an inconsistent minimum note length:
predict
it's 127.7 ms (11 frames)predict_and_save
the default is 58 msmodel_output_to_notes
the default is 5 framesI can make a PR to make it consistently 127.7 ms (11 frames), but that would be backwards incompatible. Is this acceptable?