Zvo/resume errors - Githubissues

spotify / cassandra-reaper

Software to run automated repairs of cassandra

235 stars 60 forks source link

Zvo/resume errors #107

Closed rzvoncek closed 9 years ago

rzvoncek commented 9 years ago

This PR fixes a few things:

there was a race condition that could cause a repair run to get stuck
removes several ReaperException throw declarations because they were ineffective
allows resuming ERROR repair runs (requested by #106)
mitigates one path a run could end up in ERROR state

Bj0rnen commented 9 years ago

:-1: I would suggest retrying from the getRangeToEndpointMap exception directly, rather than resurrecting from ERROR. Otherwise, we would need two error states: unrecoverable and (maybe) recoverable. Because we can't have reaper trying to infinitely restart unrecoverably failed repairs.

Bj0rnen commented 9 years ago

:+1: