search

spotify / cassandra-reaper

Software to run automated repairs of cassandra
235 stars 60 forks source link

Sly/incremental repair support #121

Closed djsly closed 6 years ago

djsly commented 9 years ago

Starting with Cassandra 2.1.X , the repair feature requires a new parameter related to incremental mode.

This PR force the usage of Cassandra 2.1.X API and enables the incremental repair parameter

zznate commented 9 years ago

@djsly Just sent a PR to Nuance fork that should fix the merge conflicts so this can be brought back into spotify's repo.

Bj0rnen commented 9 years ago

I have looked at the commits here, and they seem fine. We will hold off on testing this until the Nuance fork is sorted out. Am I correct in assuming this isn't compatible with 2.0 clusters because of the extra argument to the forceRepairRangeAsync method?

zznate commented 9 years ago

Am I correct in assuming this isn't compatible with 2.0 clusters because of the extra argument to the forceRepairRangeAsync method?

Good point (I actually did not verify with 2.0). If this is the case, I'd like to see this be backwards compatible and am willing to work on that. I'd like to propose we do this under a separate ticket though so we can sort this merge out first.

djsly commented 9 years ago

Correct, this isn't backward compatible.

On Thu, Nov 12, 2015 at 12:29 PM, Nate McCall notifications@github.com wrote:

Am I correct in assuming this isn't compatible with 2.0 clusters because of the extra argument to the forceRepairRangeAsync method?

Good point (I actually did not verify with 2.0). If this is the case, I'd like to see this be backwards compatible and am willing to work on that. I'd like to propose we do this under a separate ticket though so we can sort this merge out first.

— Reply to this email directly or view it on GitHub https://github.com/spotify/cassandra-reaper/pull/121#issuecomment-156175492 .