search

spotify / chartify

Python library that makes it easy for data scientists to create charts.
Apache License 2.0
3.53k stars 324 forks source link

Support for bokeh 3.1.0 (>2.0.0) #153

Closed vanHekthor closed 1 year ago

vanHekthor commented 1 year ago

What this PR does / why we need it: Makes chartify compatible with bokeh versions >2.0.0 (latest is 3.1.0) Which issue(s) this PR fixes

fixes #128

Special notes for your reviewer:

Release note:

Support newer bokeh versions (>2.0.0)
vanHekthor commented 1 year ago

There is a bug in bokeh (probably version 3 and later) where select(CategoricalColorMapper) returns [] (see here).

This causes some tests to fail.

Thanks to bryevdv I was able to figure out a workaround.

vanHekthor commented 1 year ago

@iampelle Maybe support for python <3.8 can be dropped?

Support for Python 3.7 was removed and for 3.10 added.

see https://github.com/bokeh/bokeh/wiki/Migration-Guides#py-300

iampelle commented 1 year ago

@iampelle Maybe support for python <3.8 can be dropped?

Support for Python 3.7 was removed and for 3.10 added.

see https://github.com/bokeh/bokeh/wiki/Migration-Guides#py-300

Yes, it's about time we drop support for py 3.6 and 3.7! And then we can require bokeh>=3 so that we don't have to check for that, right?