search

spotify / completable-futures

Utilities for working with futures in Java 8
Apache License 2.0
393 stars 51 forks source link

.allAsList() ordering #2

Closed dflemstr closed 8 years ago

odsod commented 8 years ago

+1 - looks good to me

mbruggmann commented 8 years ago

Given the complexity of the patch I'd really like to understand why we need it. I'll come bug you about it tomorrow @dflemstr.

mbruggmann commented 8 years ago

After having a look at this in person, we found the source to be a different issue (mainly how Lists.transform in Guava is lazy), so it doesn't affect the existing implementation. @dflemstr will make new PR(s) for the method signature and the exception handling in the test.