search

spotify / completable-futures

Utilities for working with futures in Java 8
Apache License 2.0
393 stars 51 forks source link

fix(compose): Prevent thread blocks by waiting on all futures #34

Closed ccarpita closed 8 years ago

ccarpita commented 8 years ago

The tests expose that the thread will block indefinitely on an incomplete future for order-4 and order-5 composes. The fix is to call allOf on all provided futures.

ccarpita commented 8 years ago

@mbruggmann @mattnworb

mbruggmann commented 8 years ago

:+1: nice catch!

codecov-io commented 8 years ago

Current coverage is 84.31%

Merging #34 into master will not affect coverage as of 5fc9b15

Powered by Codecov. Updated on successful CI builds.