search

spotify / completable-futures

Utilities for working with futures in Java 8
Apache License 2.0
393 stars 51 forks source link

Added a `Function6` #56

Closed mmscibor closed 7 years ago

mmscibor commented 7 years ago

This has been coming up fairly often recently, as often there will be futures coming in pairs (and I'll have 3 pairs).

codecov-io commented 7 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #56   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       63     69    +6     
=======================================
  Files             5      6    +1     
  Lines           162    191   +29     
  Branches          9      9           
=======================================
+ Hits            162    191   +29
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/spotify/futures/Function6.java 100% <100%> (ø) 2 <2> (?)
...n/java/com/spotify/futures/CompletableFutures.java 100% <100%> (ø) 41 <4> (+4) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d617a83...423c29e. Read the comment docs.

dflemstr commented 7 years ago

Lgtm but please don't decrease test coverage!

mmscibor commented 7 years ago

@dflemstr added the unit tests to preserve coverage

mattnworb commented 7 years ago

I cut a release for 0.3.2 with this in it.