spotify / completable-futures

Utilities for working with futures in Java 8
Apache License 2.0
393 stars 51 forks source link

Implement combine with arbitrary number of stages #61

Closed spkrka closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #61 into master will not change coverage by %. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #61   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        69        80   +11     
===========================================
  Files              6         7    +1     
  Lines            191       212   +21     
  Branches           9        14    +5     
===========================================
+ Hits             191       212   +21     
Impacted Files Coverage Δ Complexity Δ
...main/java/com/spotify/futures/CombinedFutures.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...n/java/com/spotify/futures/CompletableFutures.java 100.00% <100.00%> (ø) 45.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4e1934...5b78ba1. Read the comment docs.

spkrka commented 4 years ago

@mbruggmann @dflemstr - would this be ok to merge?