UnmodifiableFuture?

[trustin]

When returning a CompletableFuture to a caller, I sometimes need to make sure it is never completed by the caller. I could return a CompletionStage but it is still possible for a user to misuse it by converting it with toCompletableFuture().

So, I wrote a new class called UnmodifiableFuture:

• https://github.com/trustin/armeria/blob/930446cc6fc74ac65bd62bea43a246c28b06ad6d/core/src/main/java/com/linecorp/armeria/internal/UnmodifiableFuture.java

Are you interested in making this a part of completable-futures? Then, I'd be happy to polish it a little bit and send a pull request.

[spkrka]

Couldn't you just return x.thenApply(Function.identity()) instead of x to prevent x from being completed by the caller?

[trustin]

It doesn't prevent a user from completing the returned future anyway. If it's passed to some other component, then we have the same problem, and I'd like to avoid using thenApply(Function.identity()) whenever I pass it around. It also creates an additional future object.

[trustin]

Also, we can create a singleton UnmodifiableFuture that's been completed with null and reuse it in many places, which is a GC-wise win.

[spkrka]

What about https://docs.oracle.com/en/java/javase/12/docs/api/java.base/java/util/concurrent/CompletableFuture.html#minimalCompletionStage() ? Can't that be used instead?

[trustin]

Not in Java 8, because it's added in 9. :sob: (It's also less verbose to call .join() or .get() because minimal stage must be converted to future.)

[mattnworb]

I like the idea 👍

[trustin]

Gentle ping :wink: