search

spotify / dataenum

Algebraic data types in Java.
Apache License 2.0
166 stars 16 forks source link

Ensure generated code doesn't cause FindBugs/SpotBugs violations #18

Closed pettermahlen closed 6 years ago

pettermahlen commented 6 years ago

This helps prevent SEO_SUBOPTIMAL_EXPRESSION_ORDER and SPP_EQUALS_ON_ENUM

codecov-io commented 6 years ago

Codecov Report

Merging #18 into master will increase coverage by 0.08%. The diff coverage is 97.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     93.55%   93.64%   +0.08%     
- Complexity      196      207      +11     
============================================
  Files            23       23              
  Lines           621      645      +24     
  Branches         83       89       +6     
============================================
+ Hits            581      604      +23     
  Misses           30       30              
- Partials         10       11       +1
Impacted Files Coverage Δ Complexity Δ
...um/processor/generator/data/OutputSpecFactory.java 93.33% <ø> (-0.42%) 4 <0> (ø)
...com/spotify/dataenum/processor/data/Parameter.java 100% <100%> (ø) 6 <2> (+1) :arrow_up:
...spotify/dataenum/processor/parser/ValueParser.java 98.11% <100%> (+0.15%) 15 <0> (+2) :arrow_up:
...um/processor/generator/value/ValueTypeFactory.java 97.71% <100%> (+0.24%) 49 <3> (+7) :arrow_up:
...m/processor/generator/data/OutputValueFactory.java 85.1% <80%> (-1.57%) 17 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70c1a4d...abdf7a7. Read the comment docs.