search

spotify / docker-maven-plugin

INACTIVE: A maven plugin for Docker
Apache License 2.0
2.66k stars 575 forks source link

Remove mandatory email from server settings #318

Closed pierremorel-enactor closed 7 years ago

pierremorel-enactor commented 7 years ago

This is similar to https://github.com/spotify/docker-maven-plugin/issues/89

We use Config File Provider Plugin and Credentials Plugin for managing the Maven settings.xml file in our build farm. Those plugins will stitch credentials into a settings.xml at the beginning of a build, but the XML stanzas they stitch into the settings.xml file look like this:

<server>
<id>server_id</id>
<username>...</username>
<password>...</password>
</server>

No <configuration><email>...</email></configuration> entries are created.

However, since the issue was resolved, docker login no longer require the email address. See https://github.com/docker/docker/pull/16183 (merged in docker 1.11)

Could we relaxed the email restriction as we are not currently able to use Jenkins + Credentials Plugin + Spotify Maven Plugin.

vromero commented 7 years ago

If compatibility will older versions is an issue, it could perhaps be possible to set a default email in the plugin configuration.