search

spotify / docker-maven-plugin

INACTIVE: A maven plugin for Docker
Apache License 2.0
2.66k stars 575 forks source link

Update docker client to latest (8.5.0) #334

Closed unicolet closed 7 years ago

unicolet commented 7 years ago

Fixes #333 preparatory step for when docker client ships with https://github.com/spotify/docker-client/pull/744

@mattnworb it's me again ;-)

mattnworb commented 7 years ago

I'm in the process of release docker-client:8.5.0 now

unicolet commented 7 years ago

Yes thanks

On May 18, 2017 7:26 PM, "David Xia" notifications@github.com wrote:

@davidxia commented on this pull request.

In pom.xml https://github.com/spotify/docker-maven-plugin/pull/334#discussion_r117306585 :

@@ -125,7 +125,7 @@

com.spotify docker-client - 5.0.1 + 8.4.0

I'm assuming you're going to use 8.5.0 when it's released?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spotify/docker-maven-plugin/pull/334#pullrequestreview-39003929, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkkV5WGi0qyPKR0UROQeH37_d8x9nxBks5r7H9jgaJpZM4Nfd74 .

mattnworb commented 7 years ago

8.5.0 is released; i think it sometimes takes maven central a few hours to be updated.

unicolet commented 7 years ago

Bumped docker-client to 8.5.0 :-)

Done a test locally and the connection pool problem is gone (and the rest still works :stuck_out_tongue: ), yay!

mattnworb commented 7 years ago

Thanks!

unicolet commented 7 years ago

@mattnworb thanks, do you think you can ship a new version of the plugin with this PR? Thanks again :-)

mattnworb commented 7 years ago

@unicolet I just released 0.4.14.

unicolet commented 7 years ago

@mattnworb THANK YOU!