search

spotify / docker-maven-plugin

INACTIVE: A maven plugin for Docker
Apache License 2.0
2.67k stars 575 forks source link

autoPull on image level (not global) #344

Closed ocker-docker-gummi-klokker closed 6 years ago

ocker-docker-gummi-klokker commented 7 years ago

Description

autoPull is a global configuration that is not allowed per image. This is a problem if we have an integration test that first build an image and then pull another image. If autoPull is true, the test fails because it is not able to pull the locally build image. If autoPull is false, changes to a previously pulled image are not picked up i.e. at the first run the first image is build and the other image is pulled, but if we make changes to the pulled image (build and push a change on another build machine), these changes are not picked up on the following runs because we can't explicitly set autoPull to true on the dependent image.

Fix 1: Add a per image autoPull option (preferred solution) Fix 2. If the global autoPull option is set to true, and any of the pulls fails, try to use locally build images.

Software:

davidxia commented 6 years ago

@ocker-docker-gummi-klokker Thanks for the idea. Unfortunately, since this project is in bug-fix only mode, we probably won't be able to accommodate this feature. :(

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.