search

spotify / docker-maven-plugin

INACTIVE: A maven plugin for Docker
Apache License 2.0
2.66k stars 575 forks source link

OpenSource or not? #358

Closed karlnicholas closed 6 years ago

karlnicholas commented 6 years ago

Description

18 pull requests ignored

How to reproduce

check github

What do you expect

pull requests addressed

What happened instead

pull requests ignored

Software:

Full backtrace

Pull request.
mattnworb commented 6 years ago

Hi @karlnicholas, as mentioned in the README and CONTRIBUTING.md, we don't plan on making major contributions to this repository going forward as we instead are using https://github.com/spotify/dockerfile-maven for many internal projects.

Spotify open sources code in the hopes that the work we have done is useful to others. In the lifetime of this repository we have about 20 contributors from outside Spotify and we've closed 135 issues.

We are happy to accept pull requests and review issues when we can, but our time has to compete with other priorities and we also have to balance changes to the source code with how we use the code internally. The same is true of our other open source repositories related to Docker (docker-client, dockerfile-maven, docker-gc, etc).

If we are not able to review PRs as fast as contributors would like, or able to accept proposed changes or resolve issues in a way that the reporters would like, forking the code is always an option that we would have no problem with. Our goal with open sourcing code is to contribute back to the community, not to create or maintain the single "build docker images from Maven" plugin or to have a single project that solves every docker/maven need.

If there is a specific PR or issue you would like to have reviewed it would be more constructive to poke people in that PR or issue.

karlnicholas commented 6 years ago

I was looking for the EXPOSE option because OpenShift (Kubernetes?) needs to have a EXPOSE in the dockerfile for a service to be created when I create a new application from an image. Turns out that feature has been added. A documentation update would be useful. Thanks.

rhuss commented 6 years ago

@karlnicholas another option would be to switch to https://github.com/fabric8io/docker-maven-plugin which is the last docker-maven-plugin supported. You find a full-featured documentation at https://dmp.fabric8.io/

karlnicholas commented 6 years ago

@rhuss -- looks great thanks for heads-up.