search

spotify / docker-maven-plugin

INACTIVE: A maven plugin for Docker
Apache License 2.0
2.66k stars 575 forks source link

skip docker build when packaging is pom #404

Closed vineethkiv closed 5 years ago

vineethkiv commented 5 years ago

Description

The docker build is skipped when the project packaging is pom. Change committed 3 years ago in 2015 in BuildMojo.java > weShouldSkipDockerBuild() Release in may 2018. Any specific reason to do this?

How to reproduce

Create maven project with packaging as pom and include docker maven plugin.

What do you expect

Expect to build the project even when the packaging is pom.

What happened instead

Skipped docker build for projects with pom packaging.

Software:

Full backtrace

mattnworb commented 5 years ago

A project with packaging=pom does not produce any jar files. What do you want to be inside the docker image for the project?

bguerin commented 5 years ago

It can be POM packaging because nothing else is better ... I wrap npm / bower build into a Maven one, to produce a zip file of an angular app. This zip is transformed to a docker image All of this into one maven project What kind of packaging should I use ?

vineethkiv commented 5 years ago

I have some projects to dockerize the nginx configurations.

awallat commented 5 years ago

We have the same problem! We have several multi-module projects where we have a "distribution"-module, which takes care of the docker image creation. Since this is a POM-project the image is not being build anymore with version 1.1.1.

Using Version 1.0.0 of the docker-maven-plugin still works!

So either remove this check or add an option that let's us disable this check.

PatrickOsborne commented 5 years ago

I have the same problem. I build a custom mongo image for my java/scala services. This worked in 1.0.0 and then I upgraded to 1.2.0 so that the plugin would work with newer version of docker for mac.

Can we get the flag added back in?? Or could someone show me where in the code to look and I can create a PR.

Thanks, Patrick

disrvptor commented 5 years ago

Here's the commit in case anyone can get this team to accept a pull request https://github.com/spotify/docker-maven-plugin/commit/ae2e50496ea00f0960f54bdbc6c800bfa4357456

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dcfsc commented 5 years ago

We are building a Docker image in a submodule and with 1.2.0 it is now being skipped. There is no artifact to be stored in the Maven local repo, and there is no "none of the above" value in the Maven Packaging options, so pom is it.

We could make a PR to check a setting before the build gets skipped, I suppose, but I am really curious what the use case for the original change was.

Perhaps the newer dockerfile-maven-plugin will not do this.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bguerin commented 5 years ago

We gave up on this plugin, and migrated to dockerfile one. This one does not block on POM packagings

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

corentinarnaud commented 4 years ago

This bug is still happening on 1.2.1. I have a module that build and push an image on our repo. There is no need to create a jar.

smartsaif15 commented 2 years ago

This bug still exist ... unable to push image which can be created by child modules.