search

spotify / echoprint-codegen

Codegen for Echoprint
http://echoprint.me/codegen
Other
959 stars 291 forks source link

No matches when song is in DB #10

Open ghost opened 13 years ago

ghost commented 13 years ago

I've whipped up a little test program that creates a fingerprint from the 1st 20seconds and retrieves tags from the echonest api in Python.

What i've found is that either the codegen or echonest to be a little buggy; Daft Punk fingerprints come back with some very unusual results despite the files being identified by taglib (python-mutagen) and play correctly .

alastair commented 13 years ago

I get the expected results running your script over both Discovery and Homework. Can you supply the codestrings for these albums? (easiest way is find Discovery -name "*.mp3" | echoprint-codegen -s) Also, do you know any details about the source of the albums? e.g. CD rip, mp3, bitrate.

ghost commented 13 years ago

they are all cd-rip mp3's. One @256 the other @192.

The output of the command you suggest is here.

bwhitman commented 13 years ago

looking into this regomodo-- one thing, your FP code for "face to face" and a few others are empty. do you know this?

{"metadata":{"artist":"Daft Punk", "release":"Discovery", "title":"Superheroes", "genre":"House", "bitrate":256,"sample_rate":44100, "duration":238, "filename":"/media/data/Music/Daft Punk/Discovery/07 Superheroes.mp3", "samples_decoded":2622230, "given_duration":0, "start_offset":0, "version":4.11, "codegen_time":7.332185, "decode_time":12.502413}, "code_count":0, "code":"", "tag":4},
{"metadata":{"artist":"Daft Punk", "release":"Discovery", "title":"Harder, Better, Faster, Stronger", "genre":"House", "bitrate":256,"sample_rate":44100, "duration":224, "filename":"/media/data/Music/Daft Punk/Discovery/04 Harder, Better, Faster, Stronger.mp3", "samples_decoded":2473046, "given_duration":0, "start_offset":0, "version":4.11, "codegen_time":7.231982, "decode_time":12.083766}, "code_count":0, "code":"", "tag":1},
{"metadata":{"artist":"Daft Punk", "release":"Discovery", "title":"Verdis Quo", "genre":"House", "bitrate":256,"sample_rate":44100, "duration":345, "filename":"/media/data/Music/Daft Punk/Discovery/11 Verdis Quo.mp3", "samples_decoded":3802742, "given_duration":0, "start_offset":0, "version":4.11, "codegen_time":10.096123, "decode_time":19.019990}, "code_count":0, "code":"", "tag":2},
{"metadata":{"artist":"Daft Punk", "release":"Discovery", "title":"Face to Face", "genre":"House", "bitrate":256,"sample_rate":44100, "duration":240, "filename":"/media/data/Music/Daft Punk/Discovery/13 Face to Face.mp3", "samples_decoded":2648150, "given_duration":0, "start_offset":0, "version":4.11, "codegen_time":4.762547, "decode_time":10.323310}, "code_count":0, "code":"",
bwhitman commented 13 years ago

also, i don't like this:

"codegen_time":10.096123, "decode_time":19.019990

what kind of machine are you running on? there's no way a full file can take that long unless something else is messed up.

ghost commented 13 years ago

I didn't notice those empty codes. That is strange and i'd have to check I get the same on another machine.

As for the machine, Debian Squeeze on an IBM X31 (1.6GHz Pentium-M, 1GB ram). My main machine was borked at the time.

ghost commented 13 years ago

For comparison output of your command on a Debian-Squeeze,amd64,C2D@2.6GHZ, 4GB of RAM PC.

I've just listened to the album to make sure the files are not empty and they're fine.

bwhitman commented 13 years ago

thanks. so i think there are two separate issues here: one is the failure to match of known DB tracks for your query and the ohter is the long codegen times and empty codes on your X31. i'll keep this one as the failure to match (which is frankly more important to us right now) and create another one for the other one. thx