Closed RustedBones closed 1 year ago
Merging #681 (093855e) into main (96920ea) will decrease coverage by
0.12%
. The diff coverage is95.12%
.
@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 97.29% 97.18% -0.12%
==========================================
Files 57 61 +4
Lines 1701 1704 +3
Branches 112 115 +3
==========================================
+ Hits 1655 1656 +1
- Misses 46 48 +2
Impacted Files | Coverage Δ | |
---|---|---|
...ain/scala/com/spotify/featran/CollectionType.scala | 96.42% <ø> (ø) |
|
...n/scala/com/spotify/featran/FeatureExtractor.scala | 94.11% <ø> (ø) |
|
...main/scala/com/spotify/featran/FlatConverter.scala | 75.00% <ø> (ø) |
|
...a/com/spotify/featran/transformers/Binarizer.scala | 100.00% <ø> (ø) |
|
.../com/spotify/featran/transformers/Bucketizer.scala | 100.00% <ø> (ø) |
|
...spotify/featran/transformers/HashNHotEncoder.scala | 100.00% <ø> (ø) |
|
...featran/transformers/HashNHotWeightedEncoder.scala | 100.00% <ø> (ø) |
|
...otify/featran/transformers/HashOneHotEncoder.scala | 100.00% <ø> (ø) |
|
...la/com/spotify/featran/transformers/Identity.scala | 100.00% <ø> (ø) |
|
...a/com/spotify/featran/transformers/Indicator.scala | 100.00% <ø> (ø) |
|
... and 32 more |
Haven't looked too deep, but the failure with
MDL
is interesting because the proposed change seems ok? I'll also have a better look later today.