search

spotify / ffwd-ruby

An event and metrics fast-forwarding agent.
Apache License 2.0
105 stars 16 forks source link

FastForward should support booleans #11

Open ghost opened 10 years ago

ghost commented 10 years ago

If I pass FastForward a JSON boolean it fails and drops random messages.

It would be better if it could just handle the boolean and forward it.

xeago commented 10 years ago

@thiderman This is what caused the heartbeat alerts on the machine when we enabled the ingestion of metrics a week ago.

parmus commented 10 years ago

@wallesspotify The monitoring pipeline doesn't really support booleans, so this is bigger than a change in ffwd. What's blocking you from converting booleans to doubles before sending them to ffwd?

xeago commented 10 years ago

@parmus ffwd should sanitize it's input. Currently it Kernel#dup's every value, this can't be done for TrueClass/FalseClass. If you accept json as input, you should not accept a subset of json as input, but json.

udoprog commented 10 years ago

Adding this as an enhancement, it's a low hanging fruit if someone wants to pick it up.