spotify / ffwd

a flexible metric forwarding agent
https://spotify.github.io/ffwd/
Apache License 2.0
80 stars 33 forks source link

Add java-11-amazon-corretto-jdk package dep #203

Closed smstone closed 4 years ago

smstone commented 4 years ago

@lmuhlha @malish8632 @sjoeboo @RochesterinNYC

https://github.com/spotify/ffwd/pull/200 only added support for running with Corretto if it was available. These changes allow to have Corretto, Oracle, or OpenJDK satisfy the Depends field.

RochesterinNYC commented 4 years ago

Noting also that this PR/change will allow VMs/runtimes that are using the version of ffwd that will be built by this PR to purge Java 11 Oracle. Before this PR/change, since ffwd is compatible with Java 11 Corretto but still declares Java 11 Oracle as a dependency, trying to purge or remove the Java 11 Oracle apt package would result in ffwd being uninstalled/removed as well.

smstone commented 4 years ago

@RochesterinNYC we can wait until https://github.com/corretto/corretto-11/issues/113 is addressed to move forward with this.

smstone commented 4 years ago

@malish8632 @lmuhlha @RochesterinNYC We have the noalt package available to us now. Can you PTAL?